[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ic] CookieLogin with indirect_login



On Mar 7, 2007, at 3:58 PM, Kevin Walsh wrote:

Bill Carr <suppressed> wrote:
On Mar 6, 2007, at 4:47 PM, Kevin Walsh wrote:
Bill Carr <suppressed> wrote:
Is anyone using inderct_login with CookieLogin and is it working?

Not me, but I just spent a couple of minutes looking at the code.

The following patch is completely untested, but it may be worth a go:

[snip: UserDB.pm patch]

You will need to clean out your MV_USERNAME cookie after patching.

Thanks for the patch Kevin.

It looks like the real username is being set in MV_USERNAME cookie
even with an indirect_login setup. I propose keeping that behavior
the way it is and skipping the indirect login query if we got the
USERNAME from the MV_USERNAME cookie. The following patch
accomplishes that. What do you think?

[snip: UserDB.pm and Config.pm patch]

That's obviously a much bigger patch that will require a lot more testing. Unfortunately I'm not able to test your patch (nor mine) at the moment,
but I will when I get a chance.

Just out of interest, did my patch work?

No, I was not seeing PASSED_USERNAME for some reason. The indirect login query always used the real username and not the indirect_login username.

I should say I ended up with a hodgepodge setup grabbing the latest Config.pm and UserDB.pm and mixing them into my 5.4.1.

Bill Carr
Bottlenose - Wine & Spirits eBusiness Specialists
(877) 857-6700

_______________________________________________
interchange-users mailing list
suppressed
http://www.icdevgroup.org/mailman/listinfo/interchange-users


Mail converted by mhonarc 2.6.15
This archive provided courtesy of JSW4.NET, Internet Hosting Services for Small Business.