Re: [ic] email-raw usertag broken for Net::SMTP FIX

[Mike Heins <suppressed>]

Quoting Peter (suppressed):
> On 04/30/05 07:50, Mike Heins wrote:
> >Quoting Peter (suppressed):
> >
> >>Well technically it's not broken because it does specify in the docs 
> >>that it uses sendmail.  But if you use Net::SMTP for sending out emails 
> >>then no emails will be sent via this tag.  I've modified the tag to work 
> >>with Net::SMTP as well (feel free to tweak and change or whatever) and 
> >>would like to submit this to be included in future versions of 
> >>interchange.  Here's a patch to IC 5.2.
> >>
> >>Note that in theory you could eliminate all bbut the middle clause to 
> >>the if/elsif/else statement, but i wanted to keep the original 
> >>functionality of being able to send directly to sendmail rather than 
> >>simulate it through the send_mail function.
> >
> >
> >This seems like a useful idea. It just so happens that I have just
> >enhanced the [email ...] tag to do attachments with MIME::Lite,
> >and haven't yet committed it. It uses [email-raw ..] to send,
> >so I can put both in at the same time.
> 
> One thing I failed to mention before is that my patch fails to account 
> for the possibility of folded headers.  I didn't think too much of it 
> because I don't anticipate anyone using the email-raw tag to send emails 
> out with folded headers, but if you want to make it work with then an 
> additional regexp to unfold them should fix it.  Something like the 
> following before the split line should do it:
> 
> $headers =~ s/\r?\n([ \t])/$1/s;

It would seem to make sense to account for it. Can't we do so simply by
joining the @header array with a \n without stripping the headers
in send_mail?

One reason I had been avoiding all this is that the send_mail routine
is really an incredibly bad hack. It is some of the original code
in Vend 0.2, mangled year after year to wedge in more stuff. I had
always imagined I was going to make it reasonable, but instead we
ended up with send_mail, mail.coretag, email.coretag, email-raw.coretag,
etc.

-- 
Mike Heins
Perusion -- Expert Interchange Consulting    http://www.perusion.com/
phone +1.765.647.1295  tollfree 800-949-1889 <suppressed>

There's nothing sweeter than life nor more precious than time.
-- Barney
_______________________________________________
interchange-users mailing list
suppressed
http://www.icdevgroup.org/mailman/listinfo/interchange-users