[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cgiapp] CGI::Application::Dispatch::BuildURI module


Hi Michael.

> So, if I understand you correctly, there are 2 reasons for this module.
>
> 1 - When you use C::A::Dispatch you can have links that actually go to a
> module/run_mode without explicitly specifying them because you can set
> the default in the application. And these links don't look like their
> counterparts.
>
> 2 - Easily create a link to a module/run_mode pair for your templates
> when using C::A::Dispatch
>

Yes, I want to write template files more easily.


> I'm ok with the name. It seems pretty intuitive to me.

I am relieved to hear your opinion.


> Well, your module is pretty small, which means that it doesn't need many
> tests. If you're concerned about whether your test are complete enough,
> you might look at find out your test coverage. Using tools like
> Devel::Cover (or if your using Module::Build instead of MakeMaker, it's
> as easy as './Build testcover').
>
> Test coverage isn't everything, but it will help you identify obvious
> decision trees that aren't covered in your test suite.

I will learn to use some test tools and using Module::Build in future.


> Just a couple more nick-picky items:
>
> + remove the 'use 5.008006;' line from the top of you Makefile.pm.
> There's no reason to limit yourself to that strict a version of perl
> since this module would probably work for anything 5.6+
> + change line #6 of t/03move.t to have the number of test in it:
>    use Test::More tests => 3;
> You should almost always specify the number of tests that need to run
> (unless you are still developing, or the number is too dynamic).

Thanks for your advices.
When I fix these and I write documents, I will upload this module to CPAN.

Best Regards


--
Kensuke Kaneko <suppressed>

---------------------------------------------------------------------
Web Archive:  http://www.mail-archive.com/suppressed/
              http://marc.theaimsgroup.com/?l=cgiapp&r=1&w=2
To unsubscribe, e-mail: suppressed
For additional commands, e-mail: suppressed


Mail converted by mhonarc 2.6.15
This archive provided courtesy of JSW4.NET, Internet Hosting Services for Small Business.