[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cgiapp] patch to t/11callbacks.t


During my work on Class::Trigger yesterday, I noticed a small detail in the callbacks test file. It makes use of 'use base' in some places, whereas all the rest of the code makes sure to avoid it in order to preserve backwards compatibility with older versions of perl.

Attached is a patch that will help people using perl < 5.6 getting cgiapp installed.

Sun folks, enjoy :)

Rhesa


--- t/11callbacks.t.orig        2005-06-19 13:32:08.000000000 +0200
+++ t/11callbacks.t     2005-06-19 13:34:33.000000000 +0200
@@ -178,7 +178,8 @@
 ######################################
 {
        package My::Framework;
-       use     base 'CGI::Application';
+       use vars qw/@ISA/;
+       @ISA = ('CGI::Application');
        sub     cgiapp_init        { main::record_event('init')       }
        sub     cgiapp_prerun  { main::record_event('prerun')     }
        sub     cgiapp_postrun { main::record_event('postrun')    }
@@ -188,7 +189,8 @@
 ######################################
 {
        package My::Project;
-       use     base 'My::Framework';
+       use vars qw/@ISA/;
+       @ISA = ('My::Framework');
        import CGI::Application::Plugin::Foo;

# install another init callback for all users of My::Project
@@ -206,7 +208,8 @@
 ######################################
 {
        package Other::Project;
-       use     base 'My::Framework';
+       use vars qw/@ISA/;
+       @ISA = ('My::Framework');
        import CGI::Application::Plugin::Baz;
        import CGI::Application::Plugin::Bam;

@@ -225,7 +228,8 @@
 ######################################
 {
        package My::App;
-       use     base 'My::Project';
+       use vars qw/@ISA/;
+       @ISA = ('My::Project');
        import CGI::Application::Plugin::Bar;

        sub     setup {
@@ -258,7 +262,8 @@
 ######################################
 {
        package Other::App;
-       use     base 'Other::Project';
+       use vars qw/@ISA/;
+       @ISA = ('Other::Project');

        import CGI::Application::Plugin::Bam;

@@ -286,7 +291,8 @@

 {
        package Unrelated::App;
-       use     base 'CGI::Application';
+       use vars qw/@ISA/;
+       @ISA = ('CGI::Application');

        sub     setup {
                my $self = shift;

---------------------------------------------------------------------
Web Archive:  http://www.mail-archive.com/suppressed/
             http://marc.theaimsgroup.com/?l=cgiapp&r=1&w=2
To unsubscribe, e-mail: suppressed
For additional commands, e-mail: suppressed


Mail converted by mhonarc 2.6.15
This archive provided courtesy of JSW4.NET, Internet Hosting Services for Small Business.