[cgiapp] Re: Yet another callback system proposal

[Mark Stosberg <suppressed>]

On 2005-05-24, Michael Graham <suppressed> wrote:
>
>> If anyone has some time to hammer something out, I would appreciate
>> it, 'cause I have a potentially busy weekend ahead of me.  It may be
>> sufficient to take Michael's latest patch and just remove and rework
>> the order of execution.
>
> I've made a first draft of a new patch available at the following (insanely
> long) URL:
>
>     http://occamstoothbrush.com/downloads/perl/CGI-Application-4.0_3-positionless-class-callbacks-patch.tar.gz
>
> (Note that this will extract as CGI::Application-4.0_3/)
>
> Changes from 4.0_2:
>   - callback system is class based, rather than object based
>
>   - removed named positions from callback system
>
>   - the calback order is now determined as follows:
>     - the callbacks are grouped by the classes that registered them
>     - the classes are sorted according to the order of the current
>       application's ISA tree (specific to general).
>     - if one class registered more than one callback, these are called
>       on the basis of FIFO (first in, first out)
>
>   - removed 4.0_2 callbacks.t test script and added a new one
>     (11callbacks.t)
>
>   - documented the new callback system in CGI/Application.pm
>
>   - added Class::ISA as a prerequisite in Makefile.PL
>
>   - added Test::More version 0.47 as a prerequisite in Makefile.PL
>     (previously it required version 0 - we could theoretcially change
>     this to 0.31, which was when is_deeply() was added.  All I know
>     is the tests work okay here on version 0.47)
>
>   - updated MANIFEST and Changes

Thanks Michael.

On first review, this looks great to me. 

It seemed to have some whitespace differences from my tree in a few
places, but I'm not concerned about those.

I'd feel comfortable releasing this.

Feedback from others?

    Mark

--
 . . . . . . . . . . . . . . . . . . . . . . . . . . . 
   Mark Stosberg            Principal Developer  
   suppressed     Summersault, LLC     
   765-939-9301 ext 202     database driven websites
 . . . . . http://www.summersault.com/ . . . . . . . .


---------------------------------------------------------------------
Web Archive:  http://www.mail-archive.com/suppressed/
              http://marc.theaimsgroup.com/?l=cgiapp&r=1&w=2
To unsubscribe, e-mail: suppressed
For additional commands, e-mail: suppressed