Re: [cgiapp] Re: critical bug in 'import' of CGI::App 3.21 (test case available)

[Steve Hay <suppressed>]

Mark Stosberg wrote:

>On 2004-02-12, Cees Hek <suppressed> wrote:
>  
>
>>I think that perhaps it is best to just remove the need for CGI::Carp 
>>completely from CGI::Application and just use Carp instead.  Then a user 
>>that really wants to use CGI::Carp can load it themselves (CGI::Carp 
>>sets *CORE::GLOBAL::die = \&CGI::Carp::die, so CGI::Application will 
>>still use the CGI::Carp'ified die regardless of where CGI::Carp is 
>>loaded).  This isn't going to break any code, it will just mean the 
>>error messages are printed to the error log without timestamps.
>>    
>>
>
>I say 'Amen, brother!'. Can I get any other "Amen's" out there?
>
>I like the simplicity of this. I could give a hoo-ha piddly-poo if old
>applications start having a different error log format, but getting
>wacky with how importing works seems like it will be a source for
>further confusion if not actual bugs.
>
That was my original proposal ages ago, when I first wanted to be able 
to use CGI::App without CGI::Carp being loaded, but I got the impression 
at the time that people weren't keen on it.  That was the only reason 
that I submitted the import() patch in the first place.

Looks like people are a bit keener on the simplicity of just using Carp 
rather than CGI::Carp now, so that's fine with me!

- Steve



------------------------------------------------
Radan Computational Ltd.

The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only.  If you have received this message in error or there are any problems, please notify the sender immediately.  The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden.  Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd.  The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.


---------------------------------------------------------------------
Web Archive:  http://www.mail-archive.com/suppressed/
              http://marc.theaimsgroup.com/?l=cgiapp&r=1&w=2
To unsubscribe, e-mail: suppressed
For additional commands, e-mail: suppressed