[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cgiapp] Re: critical bug in 'import' of CGI::App 3.21 (test case available)


sounds like a good move to me

Mark Stosberg wrote:

On 2004-02-12, Cees Hek <suppressed> wrote:
I think that perhaps it is best to just remove the need for CGI::Carp completely from CGI::Application and just use Carp instead. Then a user that really wants to use CGI::Carp can load it themselves (CGI::Carp sets *CORE::GLOBAL::die = \&CGI::Carp::die, so CGI::Application will still use the CGI::Carp'ified die regardless of where CGI::Carp is loaded). This isn't going to break any code, it will just mean the error messages are printed to the error log without timestamps.

I say 'Amen, brother!'. Can I get any other "Amen's" out there?

I like the simplicity of this. I could give a hoo-ha piddly-poo if old
applications start having a different error log format, but getting
wacky with how importing works seems like it will be a source for
further confusion if not actual bugs.

	Mark



---------------------------------------------------------------------
Web Archive:  http://www.mail-archive.com/suppressed/
             http://marc.theaimsgroup.com/?l=cgiapp&r=1&w=2
To unsubscribe, e-mail: suppressed
For additional commands, e-mail: suppressed


Mail converted by mhonarc 2.6.15
This archive provided courtesy of JSW4.NET, Internet Hosting Services for Small Business.