[cgiapp] Re: CGI::App 3.2 proposed release available

[Mark Stosberg <suppressed>]

On 2003-11-25, Cees Hek <suppressed> wrote:
>
> thanks for keeping this stuff going.

You're welcome. Thanks for helping. :) 

> I still think I like having the header_set and header_add functions instead of
> just the header_add.  The way you have implemented header_add seems like it
> would be too easy to make a mistake in the code (ie remembering to put the [] in
> when dealing with cookie headers).  I guess the reason I went with the set and
> add style is because of the way mod_perl and apache handle headers, which is in
> the Apache::Table class.  They use add and set to modify the headers.  I was
> more aiming for the use of header_props to be depricated in later releases,
> because I think it is not the best named method in the module, and I believe it
> has caused confusion for people starting out with CGI::Application (it did with
> me anyway).

I see. It wasn't clear to me before that header_set() was meant to
replace header_props(). I agree with you thinking here-- I prefer the
functionality and name of header_set() to the way header_props() work.

My original patch to header_props() was to allow it be called multiple
times and accumulate headers. However, there were concerns about total
backwards compatibility, so that was dropped. (Although I wonder how
much it would really break...).

I think I still prefer my latest implementation of header_add(), simply
because it addresses the issues I think we care most about, while adding
less to the interface.

>
> See the patch below for a fix.

Thanks! Applied and working.

	Mark

-- 
 . . . . . . . . . . . . . . . . . . . . . . . . . . . 
   Mark Stosberg            Principal Developer  
   suppressed     Summersault, LLC     
   765-939-9301 ext 202     database driven websites
 . . . . . http://www.summersault.com/ . . . . . . . .


---------------------------------------------------------------------
Web Archive:  http://www.mail-archive.com/suppressed/
              http://marc.theaimsgroup.com/?l=cgiapp&r=1&w=2
To unsubscribe, e-mail: suppressed
For additional commands, e-mail: suppressed