[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cgiapp] Patch Proposal , CGI::Application 2.4


Respectfully submitted,


I propose the following change:

Line #156, CGI::Application (Application.pm) Version 2.4

>die ("Error executing run mode '$rm'.  Eval of code '$meth_call' resulted
in error: " . $@) if ($@);

to

Line #156, CGI::Application (Application.pm) Version 2.4

<die ($@ . "Error executing run mode '$rm'.  Eval of code '$meth_call'
resulted in error.") if ($@);

To me, it seems as if the error that occurred first should be first in the
text string.  I encountered
a desire for this as some of our sub-classes are now throwing error text
that does not mean anything to
our error handlers, because CGI::Application Line #156 is munging it.

This is obviously a small change that I could apply in house.  However, I
imagine that other people who
are creating CGI::Application sub-classes (objects lower in the class
hierarchy than the package that
defines the 'setup' method) and handling errors with eval{ } will find this
change makes the identification
and parsing of errors more predictable.


Thank you for your time,

 Cory Trese


Cory Trese
Lead Web Application Developer

O'NEIL & ASSOCIATES, INC.
495 Byers Rd.
Miamisburg, Ohio 45342-3662
Phone: (937) 865-0800 ext. 3038
Fax: (937) 865-5858
E-mail: suppressed


---------------------------------------------------------------------
Web Archive:  http://www.mail-archive.com/suppressed/
To unsubscribe, e-mail: suppressed
For additional commands, e-mail: suppressed


Mail converted by mhonarc 2.6.15
This archive provided courtesy of JSW4.NET, Internet Hosting Services for Small Business.