[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bigsister-general] *PATCH* bs web admin, problem handling groups containing "0".


I've posted this patch to the list three times before. Here it is re-done for
1.02-4.

What can I do to help ensure this patch gets applied to the trunk? I hate to
keep re-patching and I can't imagine I'm the only one with this problem.

I've made patches for 0.99b2, 0.99c3 in October of 2005. My original patch was
made in April, 2005.

Problem fixed: There's a bug in bscgi.pm which will truncate any host or group
name containing a "0". If there are two groups that truncate to the same string,
attempts to add members will fail.

ie: cisco3550-1 and cisco3550-2 will both truncate to "cisco3550" and become
difficult to manage their group membership in the admin section.


--- bscgi.pm.orig       2006-05-04 11:05:09.000000000 -0400
+++ bscgi.pm    2006-05-04 11:10:59.000000000 -0400
@@ -43,7 +43,7 @@
            for($i = 0; $i < $len; $i++) {
                my $ch;
                $ch = getc(STDIN);
-               last unless( $ch );
+               last unless( defined $ch );
                $data .= $ch;
            }
        }

Mail converted by mhonarc 2.6.15
This archive provided courtesy of JSW4.NET, Internet Hosting Services for Small Business.