[Bigsister-general] Bs web admin, problem handling groups containing "0"..

[Matt Kettler <suppressed>]

I have a problem with the bigsister (0.99c3) web "admin" function. It seems that
most input is truncated when a "0" (ascii 0x30) is reached. I also had this
problem with 0.99b2.


I attempted to create a group using:

http://<server>/bigsis/cgi/bswebadmin?function=groups&subf=create

For "group Ident" I entered "netware_7065"
For "group Name" I entered "nwservers_7065"

Upon trying to submit I get:

name not set - defaulting to netware_7
creating group netware_7 (netware_7)

I assume this is some kind of simple input parsing, where some code is looking
for a null-terminator, but winds up also accepting "0" as a terminator. (oops).

Digging around, it looks like I found, fixed, and reported a patch for this
problem. Is there anywhere I should poke to make sure this gets applied?

http://www.jsw4.net/info/list-archives/bigsister/05-04/msg00024.html


Patch attached.

--- bscgi.pm.orig       Wed Apr 27 16:40:32 2005
+++ bscgi.pm    Wed Apr 27 16:40:47 2005
@@ -42,7 +42,7 @@
            for($i = 0; $i < $len; $i++) {
                my $ch;
                $ch = getc(STDIN);
-               last unless( $ch );
+               last unless( defined $ch );
                $data .= $ch;
            }
        }